Repository navigation
Release: Windows takes NASM 2.16.03, never Chocolatey's newest - #148
Merged
Merged
Conversation
…ocolatey's newest rc4 on Namespace's Windows image installed Chocolatey's NASM, and raea.exe failed to link: 135 of openh264's SIMD routines (WelsSampleSad16x8_sse2 and the rest) unresolved, though openh264's C++ was built to call them. GitHub's image, where rc3 linked, ships NASM 2.16. The step now always unpacks the 2.16.03 zip, puts it first on PATH and fails if nasm -v names another version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rc4's Windows build (run 43493625589) failed at raea.exe's link: 135 of openh264-sys2's SIMD routines unresolved (
WelsSampleSad16x8_sse2and the rest), though its C++ was compiled to call them. That run took Chocolatey's NASM; GitHub's image, where rc3 linked, has 2.16. The nasm step now always unpacks NASM's own 2.16.03 zip, puts it first on PATH and fails ifnasm -vnames another version.Mac and Linux built warm on Namespace in this run: 36 min and 7 min (183 and 105 on GitHub's runners).