Repository navigation
A render starts 5 to 12 times sooner in a real project - #147
Closed
shinyobjectz wants to merge 3 commits into
Closed
shinyobjectz wants to merge 3 commits into
shinyobjectz wants to merge 3 commits into
Conversation
…rt cache and the bundler no longer read or stat every file under the edit's folder
…s it ran and for which models
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before a render drew its first frame, raea read or stat'ed every file under the edit's folder, twice over. In a real project that was most of a short render's time.
What it was doing
.git,node_modules, renders and media, asking each entry what it is, whether or not the bundle was cached.What changes
copy_dirnever copies (hidden folders,node_modules,target) and reads an entry's kind from the directory listing.RAEA_STARTUP_TRACE: "the composition bundled" and "the export cache looked up".Measured
Time from spawn to the first frame of an .mp4 render, bundle cache warm, on two real projects:
A 60-frame 1080p shot of the first: 4.7 s to 3.0 s end to end. Stills drawn by playing (
raea play --offscreen --seek) on the same projects, warm: 0.5 to 1.2 s; one that took 4.05 s as a one-frame render is 0.63 s.Checked
cargo test -p raea-runtime-bundle: the existing tests (an edited svg or jpeg changes the export key; a range copy is made, reused and keyed) and a new one (an edit's sources leave out hidden folders and packages).tools/agents/check --land --lane render-start: L1 ok.