Repository navigation
A ray-traced render's log no longer warns about MSAA every frame - #144
Closed
shinyobjectz wants to merge 1 commit into
Closed
shinyobjectz wants to merge 1 commit into
shinyobjectz wants to merge 1 commit into
Conversation
…each frame, Bevy turned it off and warned, once a frame in every ray-traced render's log
shinyobjectz
force-pushed
the
deferred-msaa
branch
from
November 13, 2026 19:35
2d92799 to
41a91d1
Compare
Owner
Author
|
Landed on main through the lane: 4e25222. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A camera drawn deferred (a
<SolariLighting>scene's) had MSAA turned on again every frame bymsaa_for_3d(systems/post), which Bevy'scheck_msaathen turned off with a warning: oneMSAA is incompatible with deferred rendering and has been disabledline a frame in every ray-traced render's log (60 lines for a 61-frame shot, 1,664 for a film's first run), and the camera'sMsaacomponent changed twice a frame.msaa_for_3dnow leaves a camera withDeferredPrepassalone. The picture is the same: Bevy had it off by the time the frame drew.Checked: two real ray-traced shots render with 0 such lines (60 each before), at the same frame rate (30 fps on the one compared warm);
tools/agents/check --land --lane deferred-msaa: L1 ok.