Skip to content

A ray-traced render's log no longer warns about MSAA every frame - #144

Closed
shinyobjectz wants to merge 1 commit into
mainfrom
deferred-msaa
Closed

shinyobjectz wants to merge 1 commit into
mainfrom
deferred-msaa

Conversation

@shinyobjectz

Copy link
Copy Markdown
Owner

A camera drawn deferred (a <SolariLighting> scene's) had MSAA turned on again every frame by msaa_for_3d (systems/post), which Bevy's check_msaa then turned off with a warning: one MSAA is incompatible with deferred rendering and has been disabled line a frame in every ray-traced render's log (60 lines for a 61-frame shot, 1,664 for a film's first run), and the camera's Msaa component changed twice a frame.

msaa_for_3d now leaves a camera with DeferredPrepass alone. The picture is the same: Bevy had it off by the time the frame drew.

Checked: two real ray-traced shots render with 0 such lines (60 each before), at the same frame rate (30 fps on the one compared warm); tools/agents/check --land --lane deferred-msaa: L1 ok.

…each frame, Bevy turned it off and warned, once a frame in every ray-traced render's log
@shinyobjectz

Copy link
Copy Markdown
Owner Author

Landed on main through the lane: 4e25222.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant