Repository navigation
raea play works in a folder with its own tsconfig.json - #141
Merged
Merged
Conversation
… leaves it out (it shadowed the live runtime's paths; play, the stage and played stills threw __at is not a function)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
raea play FILEthrewTypeError: (0, import_react.__at) is not a functionbefore its first frame when FILE's folder holds atsconfig.json(even{}). So did the app's stage and every still drawn by playing.raea renderwas not affected, which is why it went unnoticed: a still falls back to a render.Cause
A played composition is bundled from a work folder: its sources are copied to
work/src, andwork/tsconfig.jsoncarries thepathsthat pointreactat the live runtime. The copy took the folder's owntsconfig.jsonalong, and the bundler reads the tsconfig nearest a source, so the project's shadowed the work folder's:reactresolved to the engine's React, which has no__at.raea project newhas written atsconfig.jsoninto every project since the project layout change (for the editor), so any composition kept at a project's root beside it is affected. The 0.1.2 app's ownraeafails the same way.Fix
The work copy leaves out
tsconfig.jsonandjsconfig.json(drop_tsconfigs, after the copy). The project's own files are untouched. A project's ownpathsnever resolved from the work copy anyway (they are relative to the project).Checked
cargo test -p raea-runtime-bundle tsconfig: the copy has neither file, the sources and other JSON stay, the project keeps its own.{}and beside the scaffolded tsconfig: refused before, plays after.tools/agents/check --land --lane play-tsconfig: L1 ok.