Repository navigation
R3F: an opacity outside [0, 1] is clamped, as three draws it, instead of throwing - #117
Merged
shinyobjectz merged 1 commit intoNov 12, 2026
Conversation
… of throwing An easing that overshoots (bezier(0.34, 1.4, 0.64, 1)) gives a material opacity of 1.03; three clamps it when it draws, but the bridge handed it straight to raea's MeshBasicMaterial, whose check threw RangeError. The bridge now clamps opacity before converting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115.
A three.js material opacity outside [0, 1] (an overshooting easing gives 1.03) is clamped by three when it draws; the R3F bridge handed it straight to raea's
MeshBasicMaterial, whose check threwRangeError. The bridge now clamps opacity (indrawn()and the shadow-catcher'sShadowMaterial) before converting.Test:
sdk/r3f/test/input.test.tsx"an opacity past 1 or below 0 ... is clamped" fails without the change and passes with it.