Repository navigation
Conversation
…rds) takes() listed only video extensions, so a .wav or .mp3 under media/ was "no take ... (none)", and cutPlan's `media cuts` refuses audio anyway. Audio takes (wav mp3 m4a aac flac aif aiff ogg opus) are now listed, cut without jump-cut detection on the 30 fps grid, written to cuts.ts with kind: "audio", and the edit template plays them as <Audio>. Checked: `raea cut take.wav --at 0-1 --at 2-3` and `raea cut vo "I didn't start in tech" "That's the whole job"` on an mp3, then a render of the template edit with the tone audible. Part of shinyobjectz#89 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks. raea cut takes sound-only takes as of 09ee785 (audio files become sound clips with no shot cuts, and the edit template plays them with ). Closing as covered; the report and this PR shaped it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Mattias
Part of #89 (item 2).
raea cut take.wav --at 0-1refused withno take "tone.wav" under media/ (none). The take list only knew video extensions, and shot detection opened every take as video.What changes
engine/cli/src/native.tslists wav, mp3, m4a, aac, flac, aif, aiff, ogg and opus.cuts.tsgetskind: "audio".<Audio>. The registry is regenerated withbun tools/pack.ts.Tested on main 5b2c773
raea cut tone.wav --at 0-1 --at 2-3:REFUSED ... (none).words.jsonwritten.Rendering the template over the result gives a 2.0 s mp4 with the tone at -21.1 dB mean.
cargo test -p raea-clipasses.Also merged onto main 0ea4eab together with the other open PRs from this review: their crates' tests pass (118, 0 failed).
🤖 Generated with Claude Code