Skip to content

fix(store): add missing "lt" operator to PG filter parser #6140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gustavosbarreto merged 1 commit into from
Apr 8, 2026
Merged

fix(store): add missing "lt" operator to PG filter parser #6140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions api/store/pg/internal/filters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ func ParseFilterProperty(fp *query.FilterProperty, tableAlias string) (string, [
condition, args, err = fromBool(fp.Name, fp.Value, tableAlias)
case "gt":
condition, args, err = fromGt(fp.Name, fp.Value, tableAlias)
case "lt":
condition, args, err = fromLt(fp.Name, fp.Value, tableAlias)
case "ne":
condition, args, err = fromNe(fp.Name, fp.Value, tableAlias)
default:
Expand Down Expand Up @@ -225,6 +227,8 @@ func fromGt(column string, value any, tableAlias string) (string, []any, error)
switch v := value.(type) {
case uint, uint8, uint16, uint32, uint64, int, int8, int16, int32, int64, float32, float64:
return "? > ?", []any{qualifyColumn(column, tableAlias), v}, nil
case time.Time:
return "? > ?", []any{qualifyColumn(column, tableAlias), v}, nil
case string:
var num any
var err error
Expand All @@ -243,6 +247,34 @@ func fromGt(column string, value any, tableAlias string) (string, []any, error)
}
}

// fromLt converts a "lt" (less than) JSON expression to an SQL expression using <. It handles numeric types,
// strings, and time.Time values. Returns SQL condition string, arguments array, and error if any.
func fromLt(column string, value any, tableAlias string) (string, []any, error) {
column = mapColumnFromLegacyMongo(column)

switch v := value.(type) {
case uint, uint8, uint16, uint32, uint64, int, int8, int16, int32, int64, float32, float64:
return "? < ?", []any{qualifyColumn(column, tableAlias), v}, nil
case time.Time:
return "? < ?", []any{qualifyColumn(column, tableAlias), v}, nil
case string:
var num any
var err error

num, err = strconv.Atoi(v)
if err != nil {
num, err = strconv.ParseFloat(v, 64)
if err != nil {
return "", nil, err
}
}

return "? < ?", []any{qualifyColumn(column, tableAlias), num}, nil
default:
return "", nil, ErrUnsupportedNumericType
}
}

// fromNe converts a "ne" (not equals) JSON expression to an SQL expression using <>. Returns SQL condition string,
// arguments array, and error if any.
func fromNe(column string, value any, tableAlias string) (string, []any, error) {
Expand Down
Loading