Adds Dart support#2
Open
Levi-Lesches wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My solution to #1 (it's not a generalized solution, I just figured out how to add Dart).
Note: I added a field
projecttoCoverMeModes.sublime-settings, because some languages/environments need the test command to be run in the root of the project, but currentlybasepathis set to use the path of the file instead. I don't know how that affects Python and Go, so I just made theprojectfield optional and only used it on Dart.As an example: if you have this file structure:
Currently, when running CoverMe on
man.dart,basepathwas set tomy-coding-folder/my-project/lib/main.dart, but Dart really wants the command to be run inmy-coding-folder/my-project.Of course, every language has their own idea of what is a "package", so instead of using Dart-specific code, I simply check which folder in the Sublime project contains the path of the current file. In my case, I'd have
my-coding-folder/my-projectadded to Sublime, so that would be chosen as the project folder. And of course, if someone uses thebasepathoption in their.sublime-projectfile, they would have complete control over this manually.