Skip to content

Clarify reference comparisons when sorting by command - #925

Open
pederbe wants to merge 1 commit into
sharkdp:masterfrom
pederbe:learn/811-reference-command-sort
Open

Clarify reference comparisons when sorting by command#925
pederbe wants to merge 1 commit into
sharkdp:masterfrom
pederbe:learn/811-reference-command-sort

Conversation

@pederbe

@pederbe pederbe commented Sep 5, 2026

Copy link
Copy Markdown

Summary

Label command-sorted comparisons as faster than, slower than, or as fast as the reference, and identify the reference row. Preserve command order and the existing ratios.

Fixes #811.

Testing

  • Added a deterministic CLI regression covering faster, slower, and equal times, custom command names, command order, and one or multiple runs. Confirmed it fails before the fix and passes afterward.
  • cargo test --locked: 98 tests passed on Windows GNU with Rust 1.98.1.
  • cargo fmt --all --check: passed.
  • cargo clippy --locked --all-targets: passed with warnings in existing code and the Windows toolchain.
  • Independent static review: no actionable findings.

Linux, macOS, and minimum supported Rust were not tested locally.

@pederbe
pederbe marked this pull request as ready for review September 5, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use of both --sort command and --reference options leads to confusing relative speed table

1 participant