feat: hide network utils config when tools settings url is set#411
Open
fred-head wants to merge 1 commit into
Open
feat: hide network utils config when tools settings url is set#411fred-head wants to merge 1 commit into
fred-head wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the network utilities based tools to support fixed runtime configuration via
tools-settings.json.When a
urlis configured for one of these tools, the manual Network Utilities configuration UI is hidden and the configured values are used instead.Affected tools:
dns-testerhttps-testerdns-propWhat changed
urlis provided viatools-settings.jsonurlis configuredWhy
This keeps the current self-hosted workflow intact, while also allowing instance-level defaults through the already existing
tools-settings.jsonmechanism.That makes these tools easier to preconfigure for hosted/self-hosted deployments without forcing end users to manually enter the service URL in the UI.
Security note
tools-settings.jsonis a client-side runtime configuration file and its contents are visible to users via browser of the deployed frontend.Because of that, any
authvalue configured there should be treated as a shared service credential for self-hosted setups, not as a secret. If authentication is used, it should ideally be combined with deployment-side protections such as network restrictions, reverse proxy controls, rate limiting, etc.