Combine server host and port with strict IPv6 endpoint parsing - #3062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clients now accept
--server example.com:8388and--server '[2001:db8::1]:8388'without a separate server-port flag. Repeated endpoints retain their individual ports; legacy-s HOST -p PORTand configured fallback ports remain supported.The CLI parser validates brackets, IPv6 literals and scope IDs, and ports from 1 to 65535. Bare IPv6 is always treated as a host, never split at its last colon. Embedded ports override fallback ports regardless of option order. SIP003 rejects endpoints with conflicting ports because its interface exposes a single remote port.
Updated help, Doxygen documentation, parser/CLI regression tests, and the relay stress test to use combined endpoints.
Validation: