Update "Trigger Random Interaction" Effect - #43
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the “Trigger Random Interaction” chaos effect to better filter/validate interactions and to support delayed triggering (to allow teleporting to the interaction first), while adding new entity binding helpers for reading interaction visibility/useability conditions.
Changes:
- Add a
SUBENTITY_BINDINGhelper macro and a newSValueBoolBasicEntityBindingto read boolean sub-entity state (e.g., conditions). - Extend
SInteractionSubactionEntityBindingwith sub-entity getters for visible/useable conditions and adjust interaction pin naming/comment. - Rework
ZTriggerInteractionEffectto queue an interaction, optionally filter to useable interactions, teleport to the context object, then trigger after a short delay; also add an ImGui config toggle.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/Entity/Bindings/SValueBoolBasicEntityBinding.h |
Adds a binding for a basic boolean value entity (read-only value + pins). |
src/Entity/Bindings/SInteractionSubactionEntityBinding.h |
Adds sub-entity condition accessors (visible/useable) for interactions. |
src/Entity/Bindings/EntityBinding.h |
Introduces SUBENTITY_BINDING macro to retrieve bound sub-entities. |
src/Effects/Player/ZTriggerInteractionEffect.h |
Adds frame-update/config hooks and state for delayed interaction triggering and filtering. |
src/Effects/Player/ZTriggerInteractionEffect.cpp |
Implements interaction filtering/queuing, delayed execute, teleport-to-context, and config UI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist