Skip to content

Update "Trigger Random Interaction" Effect - #43

Merged
shadow578 merged 4 commits into
mainfrom
update/trigger-interaction-effect
Jun 4, 2026
Merged

Update "Trigger Random Interaction" Effect#43
shadow578 merged 4 commits into
mainfrom
update/trigger-interaction-effect

Conversation

@shadow578

Copy link
Copy Markdown
Owner

Checklist

  • I consent to automatic PR review by GitHub Copilot.
  • I added attributon (if applicable)
  • I updated documentation (if applicable)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the “Trigger Random Interaction” chaos effect to better filter/validate interactions and to support delayed triggering (to allow teleporting to the interaction first), while adding new entity binding helpers for reading interaction visibility/useability conditions.

Changes:

  • Add a SUBENTITY_BINDING helper macro and a new SValueBoolBasicEntityBinding to read boolean sub-entity state (e.g., conditions).
  • Extend SInteractionSubactionEntityBinding with sub-entity getters for visible/useable conditions and adjust interaction pin naming/comment.
  • Rework ZTriggerInteractionEffect to queue an interaction, optionally filter to useable interactions, teleport to the context object, then trigger after a short delay; also add an ImGui config toggle.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/Entity/Bindings/SValueBoolBasicEntityBinding.h Adds a binding for a basic boolean value entity (read-only value + pins).
src/Entity/Bindings/SInteractionSubactionEntityBinding.h Adds sub-entity condition accessors (visible/useable) for interactions.
src/Entity/Bindings/EntityBinding.h Introduces SUBENTITY_BINDING macro to retrieve bound sub-entities.
src/Effects/Player/ZTriggerInteractionEffect.h Adds frame-update/config hooks and state for delayed interaction triggering and filtering.
src/Effects/Player/ZTriggerInteractionEffect.cpp Implements interaction filtering/queuing, delayed execute, teleport-to-context, and config UI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Effects/Player/ZTriggerInteractionEffect.cpp Outdated
Comment thread src/Effects/Player/ZTriggerInteractionEffect.cpp
Comment thread src/Effects/Player/ZTriggerInteractionEffect.cpp
@shadow578
shadow578 merged commit 0d7e174 into main Jun 4, 2026
1 check passed
@shadow578
shadow578 deleted the update/trigger-interaction-effect branch June 4, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants