Skip to content

Update to SDK Version 4.0.2 - #42

Merged
shadow578 merged 4 commits into
mainfrom
update/sdk
Jun 3, 2026
Merged

Update to SDK Version 4.0.2#42
shadow578 merged 4 commits into
mainfrom
update/sdk

Conversation

@shadow578

Copy link
Copy Markdown
Owner

Checklist

  • I consent to automatic PR review by GitHub Copilot.
  • I added attributon (if applicable)
  • I updated documentation (if applicable)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project to use ZHMModSDK v4.0.2 and adjusts a few call sites to better handle max symbol conflicts (commonly caused by Windows headers), plus a small dev-tools behavior tweak.

Changes:

  • Bump ZHMModSDK version in CMake to v4.0.2.
  • Replace unqualified max(...) calls with std::max(...) in a couple of places.
  • In test mode, only auto-activate effects that are enabled.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
CMakeLists.txt Updates the ZHMModSDK version used by FetchContent to v4.0.2.
src/Helpers/ImGuiExtras.h Switches progress bar width computation to use std::max.
src/Helpers/EntityUtils.cpp Removes a max macro undef guard near the top of the file.
src/Effects/Actors/ZNearbyActorSpeakEffect.cpp Uses std::max to clamp repetition delay to non-negative.
src/ChaosModDevTools.cpp Prevents test mode from activating disabled effects.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Helpers/ImGuiExtras.h
Comment thread src/Helpers/EntityUtils.cpp
@shadow578
shadow578 merged commit 726eb4b into main Jun 3, 2026
1 check passed
@shadow578
shadow578 deleted the update/sdk branch June 3, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants