Repository navigation
Declare Composer dependencies the package uses - #132
Open
shadetheory wants to merge 2 commits into
Open
shadetheory wants to merge 2 commits into
shadetheory wants to merge 2 commits into
Conversation
Require ext-openssl, the Illuminate components called from the package, and nesbot/carbon on the Laravel 11-13 range. Require orchestra/testbench-core for the test case class. Drop illuminate/contracts, which the package does not reference. Co-authored-by: Jordan Partridge <jordan@partridge.rocks>
Add the analyser as a dev dependency and run it after composer validate. Ignore only the false positive where laravel/framework replaces illuminate/*. Co-authored-by: Jordan Partridge <jordan@partridge.rocks>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The package called OpenSSL, Carbon, and several Illuminate components without listing them in
composer.json. It only requiredilluminate/contracts, which nothing in the code references. Those packages were present only because a Laravel app installs them through other dependencies.This adds the requirements the code actually uses, with version constraints that match the supported Laravel 11, 12, and 13 range and PHP ^8.2:
ext-opensslilluminate/collections,illuminate/console,illuminate/http,illuminate/process, andilluminate/supportat^11.0||^12.0||^13.0nesbot/carbonat^2.72.6||^3.8.4(the same range Laravel 11 through 13 accepts)orchestra/testbench-coreinrequire-dev, because the test case class lives in that packageilluminate/contractsis removed.illuminate/supportstill requires it, and this package does not reference it.The requirements section in the README lists the same packages.
Test plan
composer updateresolves on the supported Laravel and PHP rangecomposer validate --strict --no-check-lockvendor/bin/pest