Skip to content

factory(78): #50 Document core package role (close #51 as dup) - #131

Open
shadetheory wants to merge 2 commits into
masterfrom
factory/78
Open

shadetheory wants to merge 2 commits into
masterfrom
factory/78

Conversation

@shadetheory

Copy link
Copy Markdown
Owner

Factory job 78 (pfc), model ollama/qwen3-coder-next:48k.

Checks:

  • vendor/bin/pint --test: pass
  • vendor/bin/phpstan analyse --memory-limit=1G: pass
  • vendor/bin/pest: pass

Diff lines: 230

Labeled do-not-merge: the label is cleared only after Lexi or a person confirms the diff matches the issue. Nothing clears it automatically.

opened by local-factory; do not auto-merge

@shadetheory shadetheory added do-not-merge local-factory PR: cleared only after Lexi or a person confirms the diff matches the issue risk:low Routine change labels Oct 26, 2026

@lexi-chief-of-staff lexi-chief-of-staff Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it.

  • Minor doc example typo flagged inline (undefined $repo variable).
  • All checks green, docs consistent with title and existing architecture.
  • Blocking: none.

Comment thread docs/3WAY-CLI-PATTERN.md
# Test the GitHub API connection
php artisan github-client test

# Show repository information

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example uses undefined $repo on RHS: $repo = Github::repos()->get($repo);. Should be a literal like get('owner/repo') or introduce a prior assignment.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 3819b15: the example now builds a Repo with Repo::fromFullName('laravel/framework') and passes it to get() and delete(). pint, phpstan and pest pass locally.

@shadetheory

Copy link
Copy Markdown
Owner Author

Quality Gate: success

All quality checks passed.

Quality Check Results

All tools passed without violations.

@shadetheory shadetheory removed the do-not-merge local-factory PR: cleared only after Lexi or a person confirms the diff matches the issue label Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Routine change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant