feat(profile-family): add D2 employee profile resources#106
Open
sgerrand wants to merge 5 commits into
Open
Conversation
…t Types Adds Humaans.IdentityDocuments (full CRUD) covering /api/identity-documents and Humaans.IdentityDocumentTypes (list-only) covering /api/identity-document-types. The list-only module declares actions [:list] and a guard test asserts the other CRUD functions are not exported.
Adds Humaans.EmergencyContacts covering /api/emergency-contacts. Each contact records the person, name, relationship, phone number, and email.
Adds Humaans.Equipment (full CRUD) plus the read-only catalog resources Humaans.EquipmentTypes and Humaans.EquipmentNames covering the corresponding /api/equipment* endpoints.
Adds the three Public Holiday API resources: - Humaans.PublicHolidays (list-only) - Humaans.PublicHolidayCalendars (list-only) - Humaans.PublicHolidayCalendarDays (list, retrieve, create, update — the API does not expose DELETE) The PublicHolidayCalendarDays module declares actions [:list, :retrieve, :create, :update] explicitly and a guard test asserts delete/2 is not exported.
Coverage Report for CI Build 25328859990Coverage decreased (-3.9%) to 96.087%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💁 These changes round out the employee-profile API surface with 9 resources from Group D2.
Summary
Full CRUD:
Limited operations:
Read-only (list):
Each resource ships as struct + module + tests using `Humaans.Resource`. Modules with restricted action sets declare `actions: [...]` explicitly and include guard tests confirming non-exported functions stay unexported.
Module access helpers and README updated.
Addresses Group D2 of the API coverage review (`~/.claude/plans/review-the-api-documentation-swirling-scroll.md`).
Test plan