Conversation
vilicvane
marked this pull request as ready for review
September 7, 2026 14:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two disjoint holes appear before their enclosing contour,
organiseBlueprintscan treat one hole as a separate filled region. This also affects text glyphs such as DejaVu SansB, producing overlapping solids and incorrect embossed or engraved text.groupByBoundingBoxOverlapassigns a tentative group to later overlapping contours. When both holes overlap the same outer contour, the second assignment overwrites the first without merging the existing groups. Containment is then evaluated separately, so one hole loses its outer boundary.This change joins connected bounding-box groups with a disjoint-set structure before collecting contours. It preserves input order within groups and first-seen group order. The existing containment and geometry-building logic remains in use.
Minimal reproduction
No font file is needed:
The expected result is one solid with two holes and volume 92. Before this change, the result contains two overlapping solids with a summed volume of 100 and only one recognized hole.
Validation
npm run prepare-packagesnpm test— all 163 tests pass across the four tested workspaces.npm run typechecknpm run build --workspace=studionpm run build --workspace=replicad-app-examplegit diff --check.