Add support for Gateway-Api HTTPRoutes and TCPRoutes#58
Open
FernandoRoldan93 wants to merge 5 commits intosftpgo:mainfrom
Open
Add support for Gateway-Api HTTPRoutes and TCPRoutes#58FernandoRoldan93 wants to merge 5 commits intosftpgo:mainfrom
FernandoRoldan93 wants to merge 5 commits intosftpgo:mainfrom
Conversation
Member
|
Hi @FernandoRoldan93 , thanks for the PR. I think a few adjustments are needed before we can merge:
I've merged/reimplemented several PRs between yesterday and today, but I need to switch to other tasks right now. Please let me know if you'd like to add the suggested additions. I'll get back to reviewing the PRs on this repository as soon as I have another time slot available. Thanks in advance. |
Author
|
Hello! I've just added the changes you suggested. Let me know if you find something else to change. Thanks! |
|
Any chance to get this merged soon ? The ingress-nginx EOL (end of this month) is approaching. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for HTTPRoutes and TCPRoutes, enabling the use of SFTPGo in clusters that use Gateway API compatible ingress controllers. Close #56