fix: chi route pattern for metric cardinality protection#15
Merged
Conversation
Replace the status-code heuristic (treating 404/0 as high-cardinality) with chi.RouteContext().RoutePattern(). Empty pattern or "/*" (unregistered routes, scanner traffic) map to "other"; registered routes use their pattern directly. This catches 403/405 scanner responses that slipped past the old check. Update logger_test to drive requests through a chi router so route patterns are populated, and drop the "redacted for cardinality protection" string check. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sethgrid
force-pushed
the
fix/metric-cardinality-status-zero
branch
from
4ffbd6f to
0082d00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
status == 404 || status == 0) withchi.RouteContext().RoutePattern()as the Prometheus endpoint label/*) map to"other"; registered routes use their exact patternPOST /form/admin/import→ 405 from a catch-all file server)path_high_cardinalityfor debugging without polluting metric labelsTest plan
go test ./logger/...—TestMiddlewareCardinalityProtectionpasses with chi router providing route context🤖 Generated with Claude Code