fix: treat ww.Status()==0 as 404 for metric cardinality protection#14
Merged
Conversation
chi's WrapResponseWriter returns 0 when WriteHeader is never explicitly called (unmatched routes). Without this fix, scanner traffic hitting arbitrary paths bypasses the redaction check and pollutes Prometheus label cardinality. Adds table-driven tests covering the known-path, explicit-404, and status-0 cases. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chi'sWrapResponseWriter.Status()returns0whenWriteHeaderis never explicitly called (unmatched routes, scanner traffic hitting arbitrary paths)http.StatusNotFound, so status-0 responses bypassed redaction and polluted Prometheus label cardinalitystatus == 0the same as404— redact the path and log it separately underpath_high_cardinalityTest plan
logger/logger_test.gocovers three cases: known path (no redaction), explicit 404 (redacted), status 0 / unmatched route (redacted)go test ./logger/...passes locally🤖 Generated with Claude Code