Record what staging the AWS apply found before it happened - #95
Merged
Merged
Conversation
Three defects, none of which any test here could have caught, all found by writing out the sequence someone would run and asking of each step what it needed that nothing provided. They belong in "What 'done' means here" because they are a different answer to the same question as the five entries above it. Those are about a test that existed and was weaker than it looked, or a claim nobody checked. These are about code no test could reach: the cloud profiles have never been applied, so a whole layer of the repository has only ever been read. The entry keeps three things that are easy to lose. tests/preflight-static exists for exactly the seam the first defect sat in, and missed it -- the suite was written around the two strings someone had thought of, and host naming is the same shape and was not one of them. A suite aimed at a class of defect still only covers the instances somebody enumerated. The emulated apply could not have seen it either, because moto has no Ansible in it. The roadmap already says a profile that applies is not a cluster that works; this is that sentence with a worked example. And three known defects becoming zero known defects is a statement about what has been looked at, not about what is there. The entry says so, because the alternative reading -- that the profile is now closer to proven -- is exactly the overstatement this file exists to refuse. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three defects — #91, #94, #93 — found by staging the first real AWS apply
rather than by running it. This records them in the roadmap's "What
'done' means here" section, as a sixth entry.
Why they belong there
The five entries above it are about a test that existed and was weaker
than it looked, or a claim nobody checked. These are a different answer
to the same question: code no test could reach. The cloud profiles have
never been applied, so a whole layer of this repository has only ever
been read.
Nothing was asserted weakly and nothing had drifted. What found them was
writing down the sequence someone would actually run, in order, and
asking of each step what it needed that nothing provided.
Three things the entry keeps
tests/preflight-staticexists for exactly the seam the first defectsat in, and missed it. That suite was written around two strings one
layer produces and another consumes strictly — an
auto_joinselectorand a
leader_tls_servername. Host naming is the same shape and nobodyhad thought of it. A suite aimed at a class of defect still only covers
the instances somebody enumerated.
The emulated apply could not have seen it either, because moto has no
Ansible in it. The roadmap already says a profile that applies is not a
cluster that works; this is that sentence with a worked example.
Three known defects becoming zero known defects is a statement about
what has been looked at, not about what is there. The entry says so,
because the other reading — that the profile is now closer to proven — is
the overstatement this file exists to refuse. It also says the apply is
no cheaper than the blocker list claims: every item on that list is a
question about runtime behaviour, and none of these three was.
Verified
docs-indexandlintgreen;make docsproduced no diff, so no new H1or H2 headings. Prose wrapped at 80, tables exempt.
🤖 Generated with Claude Code