Conversation
Signed-off-by: Nico Burns <nico@nicoburns.com>
madsmtm
suggested changes
Feb 21, 2026
| extern "C" { | ||
| /// This requires that the `coretext` feature is enabled. | ||
| pub fn hb_coretext_face_create(cg_font: CGFontRef) -> *mut hb_face_t; | ||
| pub fn hb_coretext_face_create(cg_font: CGFont) -> *mut hb_face_t; |
There was a problem hiding this comment.
Suggested change
| pub fn hb_coretext_face_create(cg_font: CGFont) -> *mut hb_face_t; | |
| pub fn hb_coretext_face_create(cg_font: &CGFont) -> *mut hb_face_t; |
Similar below.
| pub fn hb_coretext_font_create(ct_font: CTFont) -> *mut hb_font_t; | ||
| /// This requires that the `coretext` feature is enabled. | ||
| pub fn hb_coretext_face_get_cg_font(face: *mut hb_face_t) -> CGFontRef; | ||
| pub fn hb_coretext_face_get_cg_font(face: *mut hb_face_t) -> CGFont; |
There was a problem hiding this comment.
Suggested change
| pub fn hb_coretext_face_get_cg_font(face: *mut hb_face_t) -> CGFont; | |
| pub fn hb_coretext_face_get_cg_font(face: *mut hb_face_t) -> *mut CGFont; |
Or If you want to make it easier to use, create a wrapper:
pub unsafe fn hb_coretext_face_get_cg_font(face: *mut hb_face_t) -> CFRetained<CGFont> {
extern "C" {
fn hb_coretext_face_get_cg_font(face: *mut hb_face_t) -> *mut CGFont;
}
let ptr = unsafe { hb_coretext_face_get_cg_font(face) };
let ptr = NonNull::new(ptr).unwrap();
unsafe { CFRetained::retain(ptr) }
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds, but I'm not confident that it's correct. Putting it up for review / discussion.