Add base64 for ByteBuf when serializer is human-readable#53
Draft
absporl wants to merge 1 commit intoserde-rs:masterfrom
Draft
Add base64 for ByteBuf when serializer is human-readable#53absporl wants to merge 1 commit intoserde-rs:masterfrom
absporl wants to merge 1 commit intoserde-rs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on the
is_human_readable()value for the serializer, either chooses a binary representation or base64. Implements the suggestion of #37 forBytesBuf.Is this functionality something that you would merge? If so, I can look into extending it to the rest of the crate and adding some tests.