-
Notifications
You must be signed in to change notification settings - Fork 2
fix(core): B3 reconcile skips missing trie nodes instead of crashing … #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
github-actions
merged 1 commit into
main
from
fix/b3-reconcile-fail-soft-on-missing-trie
May 21, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 93
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 454
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 374
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 1744
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 91
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 280
🏁 Script executed:
# Check the trie module's error type definition cat crates/sentrix-trie/src/lib.rsRepository: sentrix-labs/sentrix
Length of output: 777
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 228
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 7105
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 3312
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 46
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 2299
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 295
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 2063
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 170
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 12687
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 1434
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 3173
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 2842
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 46
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 1169
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 2244
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 895
🏁 Script executed:
Repository: sentrix-labs/sentrix
Length of output: 1510
Distinguish missing-node errors from storage/serialization failures in error handling.
Lines 428-439 catch all
trie.get()errors identically. However,trie.get()can fail with three distinct error types:SentrixError::Internal("trie: missing node ...")(node not found),SentrixError::StorageError(...)(I/O failure), andSentrixError::SerializationError(...)(deserialization failure). The current code treats them all as recoverable gaps, but storage and serialization errors indicate a fundamentally broken trie and should not be suppressed.Match specifically on
SentrixError::Internalwith a message pattern check for "missing node", and letStorageErrorandSerializationErrorpropagate. This preserves the fail-soft behavior for dangling trie nodes while preventing boot with a corrupted or unreadable trie.🤖 Prompt for AI Agents