Skip to content

Fix poetry issue githubworkflow#98

Merged
djarecka merged 4 commits intofix_json_op_issuefrom
fix_poetry_issue_githubworkflow
Apr 6, 2026
Merged

Fix poetry issue githubworkflow#98
djarecka merged 4 commits intofix_json_op_issuefrom
fix_poetry_issue_githubworkflow

Conversation

@tekrajchhetri
Copy link
Copy Markdown
Collaborator

@tekrajchhetri tekrajchhetri commented Mar 20, 2026

@djarecka I added poetry lock and it should resolve the issue. Atm, it's triggering old one.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@djarecka
Copy link
Copy Markdown
Contributor

djarecka commented Mar 21, 2026

the poetry options added leeds to an error, see the logs.
not sure why you are saying it's triggering the old one

@satra
Copy link
Copy Markdown

satra commented Mar 23, 2026

not for this PR, but i can ask claude to send a PR to structsense to move over to a uv based-workflow. i have been very happy with uv-based workflows and the speed of uv.

@tekrajchhetri
Copy link
Copy Markdown
Collaborator Author

This PR can be merged as it has fixed the issue and now unit test's re running -- @djarecka can you confirm.

@tekrajchhetri tekrajchhetri requested a review from djarecka March 23, 2026 23:25
@djarecka
Copy link
Copy Markdown
Contributor

@tekrajchhetri - yes, looks like the tests are running, however now the tests are failing, but I'm sure this is due to the changes in fix_json_op_issue, so can be discussed there. Did you take a look at the tests?

@satra - sure, happy to switched to us

@djarecka djarecka merged commit c31c07a into fix_json_op_issue Apr 6, 2026
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants