Skip to content

Allow package dirs#665

Open
nmatei wants to merge 2 commits into
sencha:ext-react-7.2.2from
nmatei:allow-packageDirs
Open

Allow package dirs#665
nmatei wants to merge 2 commits into
sencha:ext-react-7.2.2from
nmatei:allow-packageDirs

Conversation

@nmatei

@nmatei nmatei commented Sep 11, 2020

Copy link
Copy Markdown
Contributor

allowing packageDirs to be able to use our own folders for packages & more important to be able to use useWorkspaces: true in lerna.json

example packageDirs: ["${workspace.dir}../../../../node_modules/@Company"]
then use nodeModulePath 2 folders back.
@nmatei

nmatei commented Sep 14, 2020

Copy link
Copy Markdown
Contributor Author

I've seen that "@sencha/ext-webpack-plugin" took place for "@sencha/ext-react-webpack-plugin", but that is not in public repo anymore...
or entire plugin will be deprecated?

@jnsencha

Copy link
Copy Markdown
Contributor

@nmatei I've reviewed your work. Unfortunately we don't use this repository any longer, it will be removed. You are welcome to submit a PR for the webpack plugin updates to the ext-webpack-plugin package located here: https://github.com/sencha/ext-allshared/tree/ext-allshared-7.4.x/packages/ext-webpack-plugin. You can also submit a PR against this repo for the artifacts file: https://github.com/sencha/ext-allshared/blob/e89272add4019d73ba5955786a1438c1a11b3a39/packages/ext-webpack-plugin/src/artifacts.js#L196

Thanks!

@jnsencha

Copy link
Copy Markdown
Contributor

@wemersonjanuario could you review these changes as well please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants