[tom-sapletta-com]

Summary

• Add testwins tui CLI subcommand (testwins/tui_cli.py + testwins/cli.py) wrapping PyteTerminalSurface and TerminalSession for 2D ANSI/VT100 terminal surface geometry, truecolor palette (--palette), and substring (--expect-text) audits from either captured frame files (--input) or isolated PTY commands (--exec / -- <cmd...>).
• Declare pyte>=0.8.2,<1 in [project.optional-dependencies].terminal (pyproject.toml).
• Add skip-free unit and PTY CLI regression tests in tests/test_tui_cli.py.

Ticket: ticket-021

[ifuri-validator-agent]

Validator approval after policy checks for exact head 9bfe375c307bd2f59dacc22b16eb0a818b734c4c.

Ticket: ticket-021
Correlation ID: local-semcod-testwins-pr-21-ticket-021
Model: openai/cursor-auto
Reviewed diff chunks: 2
Advisory LLM verdict: REQUEST_CHANGES
Advisory summary: Reviewed all 2 diff chunk(s). The implementation adds the TUI audit subcommand and required dependency, and all protected required checks passed. However, the documented and accepted command interface is incomplete. | The visible chunk consistently builds a structured TUI audit report, optionally writes it atomically, prints it as JSON, and propagates the report exit code. No correctness or security defects are evident in the reviewed code.
Advisory findings: register_tui does not define the accepted repeatable --arg option. Consequently, documented usage such as testwins tui --exec <binary> --arg <value> is rejected by argparse instead of passing arguments to the executable. Add --arg handling and combine those values with the PTY command arguments.
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: 6492e4055443584c5be89537498c2859739ac717...9bfe375c307bd2f59dacc22b16eb0a818b734c4c
Change digest: 44586580e770a7707fa96649a2ed5a3d3dc57d1bea31bc9a2e46aaba0e31d32d
Score: 64/100 (L), estimated 73 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG

{"actual_change":{"additions":304,"base_sha":"6492e4055443584c5be89537498c2859739ac717","binary_files":0,"categories":{"code":2,"configuration":2,"docs":1,"tests":1},"change_digest":"44586580e770a7707fa96649a2ed5a3d3dc57d1bea31bc9a2e46aaba0e31d32d","comparison":"6492e4055443584c5be89537498c2859739ac717...9bfe375c307bd2f59dacc22b16eb0a818b734c4c","deletions":1,"file_count":6,"files":["project/ticket-021/README.md","project/ticket-021/intent.json","pyproject.toml","tests/test_tui_cli.py","testwins/cli.py","testwins/tui_cli.py"],"head_sha":"9bfe375c307bd2f59dacc22b16eb0a818b734c4c","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":3,"scope":4,"uncertainty":3,"validation":1},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":73,"within_budget":false},"impact":{"components":["ANSI","project","repository-root","tests","testwins"],"files":["ANSI/VT100","project/ticket-021/README.md","project/ticket-021/intent.json","pyproject.toml","tests/test_tui_cli.py","testwins/cli.py","testwins/tui_cli.py"],"public_interfaces":[],"runtime_dependencies":1},"schema":"subactor.ticket-radar/v1","score":64,"split":{"parts":[{"estimated_minutes":13,"name":"Implement ANSI","scope":["ANSI"]},{"estimated_minutes":13,"name":"Implement project","scope":["project"]},{"estimated_minutes":13,"name":"Implement repository-root","scope":["repository-root"]},{"estimated_minutes":13,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":13,"name":"Implement testwins","scope":["testwins"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-021"}

<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-021: [ticket-021] feat(tui): add first-class testwins tui CLI subcommand wrapping PyteTerminalSurface</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,30 105,51 79,85 59,71 39,56" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 73m</text></svg>

Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)

DECISION D-021-4920
TICKET ticket-021
HEAD_SHA 9bfe375c307bd2f59dacc22b16eb0a818b734c4c
CORRELATION_ID local-semcod-testwins-pr-21-ticket-021
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["docker=SKIPPING","browser=PASS","browser=PASS","unit=PASS","unit=PASS"]
INPUT required_checks = ["unit","browser"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/testwins","pull_request":21,"head_sha":"9bfe375c307bd2f59dacc22b16eb0a818b734c4c","base_sha":"6492e4055443584c5be89537498c2859739ac717","diff_sha256":"4080bde0fbc353e851dd1598451f4aafb72aa7086cc61f4f4f1e315c910c6675"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/ticket-021/README.md","project/ticket-021/intent.json","pyproject.toml","tests/test_tui_cli.py","testwins/cli.py","testwins/tui_cli.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"6492e4055443584c5be89537498c2859739ac717","head_sha":"9bfe375c307bd2f59dacc22b16eb0a818b734c4c","change_digest":"44586580e770a7707fa96649a2ed5a3d3dc57d1bea31bc9a2e46aaba0e31d32d","score":64,"complexity":"L","estimated_minutes":73,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "REQUEST_CHANGES" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"