[tom-sapletta-com]

Ticket: ticket-024

• Add pure-Python BFS connected-components fallback in detect_communities() when networkx is not installed.
• Preserve deduplicated matched-block shared_loc in recommend() when communities is empty (--no-community).
• Add unit tests in tests/test_compare.py.

[ifuri-validator-agent]

Validator approval after policy checks for exact head 7cbd5f4e53c1a6e36ba2a17ba445c0dea6bf3d68.

Ticket: ticket-024
Correlation ID: local-semcod-redup-pr-31-ticket-024
Model: gemini/gemini-3.8-flash
Reviewed diff chunks: 2
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 2 diff chunk(s). Implemented pure-Python connected-components fallback in detect_communities() when networkx is not installed, and added a deduplicated matched-nodes LOC fallback in recommend() when communities is empty. Added corresponding unit tests and all required checks passed. | Added unit tests verifying fallback behavior when communities are empty or no matches exist, ensuring matched blocks still contribute to shared LOC calculations.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: 0cbd10d40d367ddbc25d745b3643461e5708f8b4...7cbd5f4e53c1a6e36ba2a17ba445c0dea6bf3d68
Change digest: 6262f2740dfbecad428d523afa1e5a186ceeb7d1db6c7040e1c93f012e67b3cd
Score: 44/100 (M), estimated 49 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG

{"actual_change":{"additions":180,"base_sha":"0cbd10d40d367ddbc25d745b3643461e5708f8b4","binary_files":0,"categories":{"code":2,"configuration":1,"docs":1,"tests":1},"change_digest":"6262f2740dfbecad428d523afa1e5a186ceeb7d1db6c7040e1c93f012e67b3cd","comparison":"0cbd10d40d367ddbc25d745b3643461e5708f8b4...7cbd5f4e53c1a6e36ba2a17ba445c0dea6bf3d68","deletions":47,"file_count":5,"files":["project/ticket-024/README.md","project/ticket-024/intent.json","src/redup/core/community.py","src/redup/core/decision.py","tests/test_compare.py"],"head_sha":"7cbd5f4e53c1a6e36ba2a17ba445c0dea6bf3d68","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":3,"delivery":2,"scope":2,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":49,"within_budget":false},"impact":{"components":["project","src/redup","tests"],"files":["project/ticket-024/README.md","project/ticket-024/intent.json","src/redup/core/community.py","src/redup/core/decision.py","tests/test_compare.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":44,"split":{"parts":[{"estimated_minutes":13,"name":"Implement project","scope":["project"]},{"estimated_minutes":13,"name":"Implement src/redup","scope":["src/redup"]},{"estimated_minutes":13,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-024"}

<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-024: ticket-024: Fallback community detection without networkx and preserve shared LOC</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 89,56 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 49m</text></svg>

Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)

DECISION D-024-2895
TICKET ticket-024
HEAD_SHA 7cbd5f4e53c1a6e36ba2a17ba445c0dea6bf3d68
CORRELATION_ID local-semcod-redup-pr-31-ticket-024
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance / enforce=PASS","governance / remote lifecycle=PASS","test (3.13)=PASS","test (3.10)=PASS"]
INPUT required_checks = ["test (3.10)","test (3.13)"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/redup","pull_request":31,"head_sha":"7cbd5f4e53c1a6e36ba2a17ba445c0dea6bf3d68","base_sha":"0cbd10d40d367ddbc25d745b3643461e5708f8b4","diff_sha256":"4ae6f14be5ac4199fb9c7bbfdec650a00b23e64a0cd09b47952c482fa6a359e7"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/ticket-024/README.md","project/ticket-024/intent.json","src/redup/core/community.py","src/redup/core/decision.py","tests/test_compare.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"0cbd10d40d367ddbc25d745b3643461e5708f8b4","head_sha":"7cbd5f4e53c1a6e36ba2a17ba445c0dea6bf3d68","change_digest":"6262f2740dfbecad428d523afa1e5a186ceeb7d1db6c7040e1c93f012e67b3cd","score":44,"complexity":"M","estimated_minutes":49,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "gemini/gemini-3.8-flash"
ASSERT VERDICT_AUTHORITY != "ADVISORY"