docs(governance): plan new-project 0.11.0 adoption - #16
Conversation
Co-authored-by: Koru Agent <agent@coru.dev>
Co-authored-by: Koru Agent <agent@coru.dev>
Co-authored-by: Koru Agent <agent@coru.dev>
# Conflicts: # TODO.md # project/TICKETS.md Co-authored-by: Koru Agent <agent@coru.dev>
Co-authored-by: Koru Agent <agent@coru.dev>
There was a problem hiding this comment.
Deterministic Validator approval for exact head f3a8327bfaf780b0fe2e165da968ef2e7524983c.
Ticket: ticket-006
Correlation ID: goal-pr-16-ticket-006-f3a8327b
Model: openrouter/z-ai/glm-5.2
Reviewed diff chunks: 13
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 13 diff chunk(s). Governance schema and validator additions introduce approval evidence schema, delivery policy/budget/UI validation helpers, and new diagnostics. The visible code is well-structured with input validation and no security concerns. Tests pass for both 3.12 and 3.13. | This chunk adds governance validation helpers for delivery UI, architecture, validation, and intent, plus pattern coverage and policy validation refactors. Code is data-validation logic with no command execution, secret access, or workflow changes. Tests for 3.12 and 3.13 pass. | Refactor of governance validation logic into smaller helper functions (workstreams_policy_valid, integration_policy_valid, coordination_policy_valid, common_manifest_policy_valid, basic_manifest_valid, lock_standard_valid, load_managed_lock, check_managed_file). Adds v2 schema support including nonActiveStatuses, approvalEvidence, delivery, and relative_pattern_list helper usage. Logic appears semantically preserved while improving readability. Test results pass on both 3.12 and 3.13. | This chunk refactors governance validation helpers (intent validation, coordination checks, dependency cycle detection) into smaller, focused functions. The refactoring preserves existing behavior and improves readability. The new intent_fields_error function now supports an optional 'delivery' field for v2 intents, and ticket_id_list_error cleanly validates ticket IDs and duplicate detection. No security issues, untrusted input execution, or test failures are present. | This chunk refactors governance check logic into smaller, well-named functions (e.g., check_coordination, check_scope_overlaps, ticket_shared_files) and adds new checks for ticket statuses, secret detection in changed files, and machine-local absolute paths. The refactoring preserves prior behavior while improving readability and testability. No security issues identified; secret detection logic appears sound and does not expose secrets. Test results for both 3.12 and 3.13 pass. | This chunk refactors governance validation logic into focused delivery checks (budget, timebox, base SHA, architecture/component ownership, integration ownership). The code enforces strict policy limits, detects stale base SHAs, validates component mapping, and guards integration-only changes. No security issues, secret handling, or dangerous operations are present. Tests for Python 3.12 and 3.13 pass. | This chunk refactors the monolithic check_change_gate function into smaller, well-named helper functions (select_change_ticket, check_selected_ticket_state, check_workstream_change_scope, check_selected_ticket_intent, check_delivery_gate, ticket_owns_implementation, ticket_path_owners). The refactoring preserves existing governance logic while improving readability and maintainability. The approval_subject_valid validation function introduces proper schema validation for approval evidence with appropriate regex checks for repository format and SHA hashes. | This chunk refactors approval handling into modular validators and adds secure external approval-evidence loading with path traversal protection, O_NOFOLLOW usage, symlink rejection, and strict binding checks. Code is well-structured and security-conscious. | This chunk refactors governance_check.py into smaller functions (load_manifest, optional_repo_path, resolve_changed_paths, run_governance_checks, formatted_report, write_report, write_resolved_ticket) and adds new CLI arguments for approval evidence validation. The intent.schema.json is extended with a delivery object schema. The refactoring preserves existing error handling and behavior. The write_resolved_ticket function correctly prevents writing inside the repository checkout, enforcing output to a protected directory outside the checkout. Tests for Python 3.12 and 3.13 both pass. | Governance schema and package manifest updates introducing approval evidence bindings, delivery constraints, branch validation, and package-manifest file mappings. JSON schema definitions are well-formed with appropriate strictness (additionalProperties:false, uniqueItems, minItems). No security issues observed in this chunk; branch pattern and path glob guards look reasonable. | This chunk adds a work-classification DSL JSON file and its JSON schema, plus AGENTS.md and TODO.md governance documentation updates. The schema is well-formed, enforces strict additionalProperties: false, uses first-match/advisory-only LLM policy, and the DSL instance validates against the schema. AGENTS.md correctly tightens trust boundaries to protected reviewers/validator apps and clarifies markdown approval is audit-only. Tests pass for 3.12 and 3.13. | This chunk contains ticket-006 documentation, changelog, AI participant notes, logs, and intent metadata for adopting immutable new-project 0.11.0. The governance artifact version upgrade is documented with validation evidence showing passing governance checks and full test suites after a baseline repair. Test results indicate both Python 3.12 and 3.13 pass. No code or security concerns are visible in this documentation-only chunk. | Governance/evidence chunk for ticket-006 adds the preprompt and intent validation entries. Commands are deterministic and reference local tooling; no executable implementation or secrets are introduced. Tests pass.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Merge was not requested or performed.
Created by governed goal -a pull-request delivery.