Skip to content

fix(ticket-116): avoid ancestor walks in project containment checks - #149

Merged
ifuri-validator-agent[bot] merged 2 commits into
mainfrom
ticket/116-path-scope-performance
Oct 31, 2026
Merged

ifuri-validator-agent[bot] merged 2 commits into
mainfrom
ticket/116-path-scope-performance

Conversation

@tom-sapletta-com

@tom-sapletta-com tom-sapletta-com commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Project inventory repeatedly walked every ancestor for each process/project pair, causing live MCP scans to exceed 90 seconds. Compare native-case normalized anchors and component prefixes while preserving lexical boundaries, relative paths and cleanup protections.

Ticket: ticket-116

Validation: the deep-path regression fails before the fix; all 56 affected tests and the scoped Testless scan pass. Ruff passes. Full stack and protected OneDev checks validate the frozen commit before independent publication.

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation rejected:

  • Patch contains unsafe validation shortcut: @pytest.mark.skip

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator approval after policy checks for exact head 3e25a936a86f8d509f12380698da5b5e67b2f3de.

Ticket: ticket-116
Correlation ID: fixos116-3e25a93-20261031
Model: zai/glm-5.3
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). The change replaces per-comparison ancestor enumeration in _within with an anchor check plus native-case normalized component-prefix comparison. Semantics align with the previous lexical containment: equality, descendant, sibling-boundary, relative-anchor, and native-case behavior are preserved, and the new unit tests cover these boundaries plus a regression that fails if parents is enumerated. No security concerns; the change is purely a performance optimization in a containment helper and does not alter cleanup eligibility logic.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: 1badd07decd568bc1012c823354c03ee62a0981b...3e25a936a86f8d509f12380698da5b5e67b2f3de
Change digest: db570c399f9bdda37efd7c508c4089744b921b89b263fb8b662242fd3ea35d35
Score: 48/100 (M), estimated 52 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":169,"base_sha":"1badd07decd568bc1012c823354c03ee62a0981b","binary_files":0,"categories":{"code":1,"configuration":1,"docs":1,"tests":1},"change_digest":"db570c399f9bdda37efd7c508c4089744b921b89b263fb8b662242fd3ea35d35","comparison":"1badd07decd568bc1012c823354c03ee62a0981b...3e25a936a86f8d509f12380698da5b5e67b2f3de","deletions":1,"file_count":4,"files":["fixos/diagnostics/venv_cleanup.py","project/ticket-116/README.md","project/ticket-116/intent.json","tests/unit/test_path_scope.py"],"head_sha":"3e25a936a86f8d509f12380698da5b5e67b2f3de","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":4,"delivery":2,"scope":2,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":52,"within_budget":false},"impact":{"components":["fixos","process","project","tests"],"files":["fixos/diagnostics/venv_cleanup.py","process/project","project/ticket-116/README.md","project/ticket-116/intent.json","tests/unit/test_path_scope.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":48,"split":{"parts":[{"estimated_minutes":11,"name":"Implement fixos","scope":["fixos"]},{"estimated_minutes":11,"name":"Implement process","scope":["process"]},{"estimated_minutes":11,"name":"Implement project","scope":["project"]},{"estimated_minutes":11,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-116"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-116: fix(ticket-116): avoid ancestor walks in project containment checks</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 97,53 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 52m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-116-4513
TICKET ticket-116
HEAD_SHA 3e25a936a86f8d509f12380698da5b5e67b2f3de
CORRELATION_ID fixos116-3e25a93-20261031
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["test-summary=PASS","test-fedora=PASS","test-ubuntu=PASS","test-alpine=PASS","test-debian=PASS","governance / remote lifecycle=PASS","test (3.12)=PASS","governance / enforce=PASS","test-arch=PASS","test (3.11)=PASS","test (3.10)=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","test (3.10)","test (3.11)","test (3.12)","test-summary"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/fixos","pull_request":149,"head_sha":"3e25a936a86f8d509f12380698da5b5e67b2f3de","base_sha":"1badd07decd568bc1012c823354c03ee62a0981b","diff_sha256":"d6dc2037f9012894045a47d9e0080269ade9de14919286f685f389ab0c341413"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["fixos/diagnostics/venv_cleanup.py","project/ticket-116/README.md","project/ticket-116/intent.json","tests/unit/test_path_scope.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"1badd07decd568bc1012c823354c03ee62a0981b","head_sha":"3e25a936a86f8d509f12380698da5b5e67b2f3de","change_digest":"db570c399f9bdda37efd7c508c4089744b921b89b263fb8b662242fd3ea35d35","score":48,"complexity":"M","estimated_minutes":52,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit dc5de05 into main Oct 31, 2026
12 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the ticket/116-path-scope-performance branch October 31, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant