Skip to content

fix(disk, ticket-114): classify pressure from available capacity - #148

Merged
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/114-available-capacity
Oct 31, 2026
Merged

ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/114-available-capacity

Conversation

@tom-sapletta-com

@tom-sapletta-com tom-sapletta-com commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

DiskAnalyzer divided used bytes by the full filesystem capacity, including reserved blocks unavailable to ordinary processes. On this host it reported warning severity at 94% utilization while services had only about 2.5% available capacity. Four controlled cases reproduced incorrect warning or healthy results.

Classify utilization using used bytes plus available bytes. Preserve raw capacity fields and existing severity thresholds; exhausted available capacity is critical and a zero-capacity observation remains an error. Filesystem reservations and cleanup policy remain unchanged.

Validation: 15 affected tests passed, including eight capacity cases; Testless coverage collection, changed-file Ruff and managed governance passed. The complete suite runs on the independently merged proposal-fixture correction from #147; required Python matrix and protected checks remain enforced.

Ticket: ticket-114

The independent protected Validator owns exact-head approval and merge.

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator approval after policy checks for exact head 03241ff9cf3d01f56d9e8dffee920db680a61334.

Ticket: ticket-114
Correlation ID: fixos114-03241ff-20261031
Model: zai/glm-5.3
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). The change correctly recomputes disk utilization using used + free (capacity available to ordinary processes) instead of total capacity, preventing reserved blocks from masking critical pressure. Raw total/used/free fields and thresholds are preserved, zero capacity raises an explicit error, and the new tests cover reserved-block pressure, exhaustion, ordinary, empty, and zero-capacity cases. Required checks (test-summary, Python 3.10/3.11/3.12, onedev/local-verify) all pass.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: 1a03305fb891c0e643a57018676af1364c821ce9...03241ff9cf3d01f56d9e8dffee920db680a61334
Change digest: 635431ea13c78c5855a36b05a9a618baefa2380794df2aa0aa214607bdc3f722
Score: 44/100 (M), estimated 45 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":195,"base_sha":"1a03305fb891c0e643a57018676af1364c821ce9","binary_files":0,"categories":{"code":1,"configuration":1,"docs":1,"tests":1},"change_digest":"635431ea13c78c5855a36b05a9a618baefa2380794df2aa0aa214607bdc3f722","comparison":"1a03305fb891c0e643a57018676af1364c821ce9...03241ff9cf3d01f56d9e8dffee920db680a61334","deletions":1,"file_count":4,"files":["fixos/diagnostics/disk_analyzer.py","project/ticket-114/README.md","project/ticket-114/intent.json","tests/unit/test_disk_analyzer_capacity.py"],"head_sha":"03241ff9cf3d01f56d9e8dffee920db680a61334","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":3,"delivery":2,"scope":2,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":45,"within_budget":false},"impact":{"components":["fixos","project","tests"],"files":["fixos/diagnostics/disk_analyzer.py","project/ticket-114/README.md","project/ticket-114/intent.json","tests/unit/test_disk_analyzer_capacity.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":44,"split":{"parts":[{"estimated_minutes":12,"name":"Implement fixos","scope":["fixos"]},{"estimated_minutes":12,"name":"Implement project","scope":["project"]},{"estimated_minutes":12,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-114"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-114: fix(disk, ticket-114): classify pressure from available capacity</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 89,56 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 45m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-114-4513
TICKET ticket-114
HEAD_SHA 03241ff9cf3d01f56d9e8dffee920db680a61334
CORRELATION_ID fixos114-03241ff-20261031
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["test-summary=PASS","governance / remote lifecycle=PENDING","test (3.10)=PASS","test (3.11)=PASS","governance / enforce=PASS","test (3.12)=PASS","test-alpine=PASS","test-ubuntu=PASS","test-debian=PASS","test-arch=PASS","test-fedora=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","test (3.10)","test (3.11)","test (3.12)","test-summary"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/fixos","pull_request":148,"head_sha":"03241ff9cf3d01f56d9e8dffee920db680a61334","base_sha":"1a03305fb891c0e643a57018676af1364c821ce9","diff_sha256":"1f1f23fd5460da321a6c836e29c0e654863abd51ba0c01b64b34b4208233adfe"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["fixos/diagnostics/disk_analyzer.py","project/ticket-114/README.md","project/ticket-114/intent.json","tests/unit/test_disk_analyzer_capacity.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"1a03305fb891c0e643a57018676af1364c821ce9","head_sha":"03241ff9cf3d01f56d9e8dffee920db680a61334","change_digest":"635431ea13c78c5855a36b05a9a618baefa2380794df2aa0aa214607bdc3f722","score":44,"complexity":"M","estimated_minutes":45,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit 1badd07 into main Oct 31, 2026
12 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the ticket/114-available-capacity branch October 31, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant