Repository navigation
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4421 +/- ##
==========================================
+ Coverage 55.68% 56.46% +0.78%
==========================================
Files 2177 2131 -46
Lines 169048 166740 -2308
==========================================
+ Hits 94130 94151 +21
+ Misses 74913 72584 -2329
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nodes that switch FlatKV on mid-chain seed it at the height memIAVL had reached, so FlatKV has no history below that height. The composite store's read-only open and its exporter still opened FlatKV at any requested height. For a height below the seed, FlatKV fell back to its empty genesis snapshot and tried to replay from block 1, failing with "WAL starts at block N but replay must start at block 1 ... (data loss or corruption)". On atlantic-2 this broke proved
abci_querybelow the activation height and the state-sync snapshot at 274408000 on archive-0, both on v6.7.0-rc4 and on main. The node's live state was fine; up to the seed height memIAVL alone made up the AppHash. #3928 removed the earliest-version record the read path used to tell these heights apart, and pinned the failure inTestComposite_Auto_ReadOnlyPreFlatKVEraHeightNowFails.This restores pre-activation reads with a smaller record. After writing the seeded snapshot,
SetInitialVersiondurably writes the seeded height toflatkv/SEEDED_VERSION, and import removes it. FlatKV'sLoadLatestreads that record once, validates it against the store's history and caches it, exposed asSeededVersion()onLiveStateStore. The record must be a positive height no higher than the store's version, no retained non-genesis snapshot may be older than it, and the WAL's first block must come after it. A malformed record, or one the history contradicts, fails the node at open rather than letting it start and then fail historical reads, or worse, serve an in-era height without FlatKV. A record that is too low is accepted, because the heights between it and the real seed just keep failing to load.LoadVersionReadOnlyandExporterleave FlatKV out and serve memIAVL only when the version is at or below the cached seed. The view's write mode is forced to memiavl_only so fixed migration modes work too. Every other height still opens FlatKV, and a real WAL gap after activation still fails loudly.Stores seeded before this change have no record, so they keep today's behavior until an operator runs
seidb flatkv-record-seeded-version --home <home> --version <seed>with the node stopped. For archive-0 on atlantic-2 the seed is274411998. The tool applies the same validation before writing the record. The NowFails test is turned back into a positive test. New tests pin the exact seed/seed+1 boundary, the operator remediation (no record fails, recorded succeeds), open-time rejection of malformed and too-high records at both the FlatKV and composite level, re-seeding after an aborted import, and cleanup of a leftoverSEEDED_VERSION-tmp.