Skip to content

Fix #212 stale gutter, anyTargetChanged->true #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fredsa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #212 stale gutter, anyTargetChanged->true #239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/worker/builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,15 +361,16 @@ export function staleFiles(step: BuildStep, targets: string[]) {
}

export function anyTargetChanged(step: BuildStep, targets: string[]) {
if (!step.maxts) throw Error("call populateFiles() first");
// see if any target files are more recent than inputs
for (var i = 0; i < targets.length; i++) {
var entry = store.workfs[targets[i]];
if (!entry || entry.ts > step.maxts)
return true;
}
console.log("unchanged", step.maxts, targets);
return false;
// if (!step.maxts) throw Error("call populateFiles() first");
// // see if any target files are more recent than inputs
// for (var i = 0; i < targets.length; i++) {
// var entry = store.workfs[targets[i]];
// if (!entry || entry.ts > step.maxts)
// return true;
// }
// console.log("unchanged", step.maxts, targets);
// return false;
return true; // always rebuild to keep gutter in sync with source lines
}

export function fixParamsWithDefines(path: string, params) {
Expand Down
Loading