Skip to content

Assignment1#2

Open
segretid wants to merge 5 commits intomainfrom
assignment1
Open

Assignment1#2
segretid wants to merge 5 commits intomainfrom
assignment1

Conversation

@segretid
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are close.

Part 1: Good idea to compare sorted letters, but the intermediate steps (set(), len()) aren’t used, and the function is missing a return, so it doesn’t output anything.

Part 2: The approach to handle case sensitivity is on the right track, but the syntax is incorrect—you don’t need to define a new function; instead, conditionally convert both words to lowercase before comparing.

Please revise

@segretid
Copy link
Owner Author

I believe I sent over another! I hope its on track!!

@juliagallucci
Copy link

I dont see any modifications

@segretid
Copy link
Owner Author

Did it work now? It looks like I have two pull requests for some reason; I think here is the most up to date implementing the feedback! Can I merge the two pull requests that I see on my end?

@juliagallucci
Copy link

Close, however, you are not storing or returning any of your comparisons, and lower(word_a, word_b) isn’t valid—you need to reassign using .lower() when is_case_sensitive is False. Also, make sure to include a return statement so the function outputs True or False. Please revise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants