Add optional delay argument

History.md

@@ -1,4 +1,9 @@
 
+0.7.0 / 2016-12-15
+==================
+
+  * [FEATURE] Retry with optional delay
+
 0.6.0 / 2016-05-16
 ==================
 

Readme.md

@@ -23,6 +23,15 @@ function onresponse (err, res) {
 }
 ```
 
+You can optionally add a delay to each retry.
+
+```javascript
+superagent
+  .get('https://segment.io')
+  .retry(2, 500) // retry twice with 0.5 second delay
+  .end(onresponse);
+```
+
 ## Retrying Cases
 
   Currently the retrying logic checks for:

lib/index.js

@@ -22,26 +22,28 @@ module.exports.retries = retries;
 /**
  * Sets the amount of times to retry the request
  * @param  {Number} count
+ * @param  {Number} [delay] optional delay in ms
  */
 
-function retry (retries) {
+function retry (retries, delay) {
 
   var self    = this
     , oldEnd  = this.end;
 
-  retries = retries || 1;
+  retries     = retries === Number(retries) && retries || 1;
+  delay       = delay === Number(delay) && delay || 0;
 
   this.end = function (fn) {
     var timeout = this._timeout;
 
     function attemptRetry () {
       return oldEnd.call(self, function (err, res) {
-        if (!retries || !shouldRetry(err, res)) return fn && fn(err, res);
+        if (!retries-- || !shouldRetry(err, res)) return fn && fn(err, res);
 
-        reset(self, timeout);
-
-        retries--;
-        return attemptRetry();
+        setTimeout(function() {
+          reset(self, timeout);
+          attemptRetry();
+        }, delay);
       });
     }
 
@@ -65,6 +67,7 @@ function reset (request, timeout) {
   request.timeout(timeout);
   delete request.req;
   delete request._timer;
+  delete request._endCalled;
 
   for (var k in headers) {
     request.set(k, headers[k]);

package.json

@@ -1,6 +1,6 @@
 {
   "name": "superagent-retry",
-  "version": "0.6.0",
+  "version": "0.7.0",
   "description": "A retrying layer for a superagent request",
   "keywords": [
     "superagent",

test/test.js

@@ -237,5 +237,34 @@ describe('superagent-retry', function () {
           done();
         })
     });
+
+  it('should retry with delay', function (done) {
+    var requests = 0;
+    var millisecs = Date.now();
+    var url = 'http://localhost:' + port + '/timeout';
+
+    app.get('/timeout', function (req, res, next) {
+      requests++;
+      if (requests > 10) res.send('hi!');
+    });
+
+    agent
+      .get(url)
+      .timeout(10)
+      .end(function (err, res) {
+        should.exist(err);
+      });
+
+    agent
+      .get(url)
+      .timeout(2)
+      .retry(10, 20)
+      .end(function (err, res) {
+        millisecs = Date.now() - millisecs;
+        res.text.should.eql('hi!');
+        millisecs.should.above(200);
+        done();
+      });
+    });
   });
 })