Skip to content

Fix decompiler crash on stack-returned values in c_return_as_atoms #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vietd0x wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −4
Open

Fix decompiler crash on stack-returned values in c_return_as_atoms #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions angr/analyses/reaching_definitions/function_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,10 +619,15 @@ def c_return_as_atoms(state: ReachingDefinitionsState, cc: SimCC, prototype: Sim
if prototype.returnty is not None and not isinstance(prototype.returnty, SimTypeBottom):
retval = cc.return_val(prototype.returnty)
if retval is not None:
return {
Atom.from_argument(footprint_arg, state.arch, full_reg=True)
for footprint_arg in retval.get_footprint()
}
sp_value = state.get_one_value(Register(state.arch.sp_offset, state.arch.bytes), strip_annotations=True)
sp = state.get_stack_offset(sp_value) if sp_value is not None else None
atoms = set()
for footprint_arg in retval.get_footprint():
try:
atoms.add(Atom.from_argument(footprint_arg, state.arch, full_reg=True, sp=sp))
except ValueError:
continue
return atoms
return set()

@staticmethod
Expand Down