fix: correct PWA manifest branding and VitePWA config#58
Open
PragyaTripathi990 wants to merge 1 commit into
Open
fix: correct PWA manifest branding and VitePWA config#58PragyaTripathi990 wants to merge 1 commit into
PragyaTripathi990 wants to merge 1 commit into
Conversation
manifest.json had placeholder names ('My Ionic App', 'Ionic App') and was
missing description, scope, orientation, and categories. vite.config.ts had
a bare VitePWA() call with no manifest or workbox config. APP_NAME in
app-data.ts also referenced a different product ('Inventory Tracker for FVM
Warehouse'). All three are now aligned to 'Government Invoice & Billing System'.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
public/manifest.jsonhad placeholder names (My Ionic App/Ionic App) left over from scaffolding. Updated toGovernment Invoice & Billing System/GovtInvoiceand addeddescription,scope,orientation, andcategoriesfields required for a compliant PWA manifest.vite.config.tshad a bareVitePWA({ registerType: "autoUpdate" })call with no manifest configuration and no Workbox caching rules. Added the full manifest block (matchingmanifest.json) and WorkboxglobPatterns+runtimeCachingfor Google Fonts.src/app-data.tsAPP_NAMEwas set to"Inventory Tracker for FVM Warehouse"— a completely different product. Corrected to"Government Invoice & Billing System".All three values are now consistent so the app name is correct everywhere: the PWA install prompt, the email subject line, and the browser title.
Test plan
npm run build) — no VitePWA config warnings🤖 Generated with Claude Code