Repository navigation
nvn/tests: check depth-only archive buffer allocations - #2697
Open
thehobbit85 wants to merge 1 commit into
Open
thehobbit85 wants to merge 1 commit into
thehobbit85 wants to merge 1 commit into
Conversation
Abort fixture setup when either Metal buffer allocation fails before binding the vertices, copying depth into the readback buffer or dereferencing it. This fixes the extra NullablePassedToNonnull finding without changing the pixel checks or the lint baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The depth-only pipeline-archive test can receive a null vertex or readback buffer from Metal, then bind, copy into, or read it. Abort fixture setup immediately if either allocation fails, matching the existing texture check and retaining the depth and command-completion assertions.
This fixes the extra
NullablePassedToNonnullfinding int_pso_archive.m(3 findings versus the baseline's 2). The baseline stays unchanged. It is a separate shared CI repair, complementary to #2555 and the existing fixture/baseline corrections in #2476.Validation on base
2ad01cb47cfd37ccb68791671bc62068c1b9408a:make -C dm/gfx/tests GAME=010015100B514000 check_t_pso_archive: 362 checks and 14 restart/process tests passed. Also rebuilt and ran both with Xcode 27.2's compiler and macOS 27.2 SDK explicitly.make -k -j6 -C dm/gfx/tests GAME=010015100B514000 run: passed; six optional Wonder reflection samples unavailable.regress.py impact: no host entry points or mapped games reached. This changes only a native test fixture; no game run was performed. Four profiles were classified unaffected and 166 lack usage manifests.The full graphics run used the shell's Apple clang 21 from Swift 6.4.1 with the selected Xcode SDK; the affected fixture additionally passed with Xcode's clang 2100.4.1.1. Agent 2 reviewed the actual one-line diff with no actionable findings.
Current-main integration at
f226affd2f4cce7fb954d26b89d917361133745d: clean merge simulation; focused lint fails on unmodified main and passes with this guard; the 362 archive checks and 14 process tests pass again. Full C lint has the same nine above-baseline and three stale-baseline pairs listed above, with no additional diagnostics.