Repository navigation
games/0400486024DEC000: screen shape (DM_SCREEN_ASPECT) renders taller aspects without stretched HUD or transition gaps - #2651
Open
PiinoStudio wants to merge 1 commit into
Open
PiinoStudio wants to merge 1 commit into
PiinoStudio wants to merge 1 commit into
Conversation
…r aspects without stretched HUD or transition gaps With screen_aspect on and DM_SCREEN_ASPECT set (e.g. 1.6 for 16:10 MacBook or 1.333 for 4:3 iPad), places fifteen fingerprint-matched stubs under MATCH_FRAME_STEP: - Eleven height sites across graphics init, scene app init, base scene defaults, display mgr defaults, base res read, and display targets. - 3D perspective projection (sead::PerspectiveProjection::doUpdateMatrixImpl_) scaling fovyTan by k = (16/9) / ratio for Vert+ framing. - Layout2 ortho projection builders (main+0x1520c80 and main+0x773b90) scaling canvas height so HUD widgets keep 1:1 pixel aspect ratio. - Layout2 CalculateMtx (main+0x14e9980) scaling full-screen PicturePanes so scene transitions and faders cover the expanded canvas without gaps. Verified in gameplay on macOS across 16:9, 16:10, and 4:3.
github-actions
Bot
added
rewriter
|
This is an Ocarina of Time fix, writing this here so that agents can properly search for it as opposed to using the game ID |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
screen_aspect onandDM_SCREEN_ASPECTset (e.g.1.6for 16:10 MacBook displays or1.333for 4:3 iPad displays; launcher setting Picture shape), places fifteen fingerprint-matched stubs underMATCH_FRAME_STEP(others, inactive when state+0x48is 0):graphics init,scene app init,base scene defaults,display mgr defaults,base res read, anddisplay target a/b/c.sead::PerspectiveProjection::doUpdateMatrixImpl_at0x3485cc0), scalingfovyTanbyk = (16/9) / ratiofor Vert+ framing (preserving horizontal 16:9 framing with extra vertical scene view).layout orthoatmain+0x1520c80andlayout view orthoatmain+0x773b90), scaling canvas height so 2D HUD elements (hearts, buttons, minimap) keep a 1:1 pixel aspect ratio in the safe area.layout calc matrixatmain+0x14e9980), scaling full-screenPicturePaneelements (width >= 1000,height >= 700,|width*9 - height*16| < 200) so scene faders and door/warp transitions (such asP_Black_00andP_White_00inEventFade_00) cover the expanded canvas without un-faded bands at top and bottom.Verification
Verified in active gameplay on macOS (v131072, Kokiri Forest and Goron City):
16:9(0,2560x1440),16:10(1.6,2560x1600), and4:3(1.333,2560x1920) all keepheart1at68x33(h/w = 0.485, shifted vertically by half the extra height) with unstretched HUD widgets and Vert+ 3D framing.top_non_black = 0,bot_non_black = 0).python3 dm/tools/docs_patches.py --check) and test suite pass cleanly.