Repository navigation
chain: NVN2 images picked at run time: c2 slot arrays and an image pool for handles from memory - #2616
Open
FifteenPen wants to merge 3 commits into
Open
chain: NVN2 images picked at run time: c2 slot arrays and an image pool for handles from memory#2616FifteenPen wants to merge 3 commits into
FifteenPen wants to merge 3 commits into
Conversation
…lot arrays, element k = image slot k (tex_dyn_slots)
…indexes an image pool by its ID, so The Duskbloods' fog volume is written
FifteenPen
force-pushed
the
pr/nvn2-image-handles
branch
from
November 14, 2026 08:36
3d59039 to
2c20122
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NVN2 image handles the translator couldn't trace, found on The Duskbloods network test (and needed by Persona 3 Reload):
tex_dyn_slots, as for textures).GXFogVolume_*, reads its 3D image handle from storage buffer 0) can't be a slot array, because the index is the image ID itself. It now indexes an image pool by ID: a new reflection kind,img_pool, gets a table filled by the replay with the bound images (the write sink elsewhere). Without it the fog volume was never written and the world drew black behind the HUD. Covered bytest_dmsh_pool_arrays.py.dmsh_xlaterebuilt (native tools, arm64 + x86_64), with the lock and the chain header.Rebased on main: SULD / SUST through a register, the first commit here before, is in main already (4032a11), so it is dropped.