fix(web): open the profile view when "My Profile" is clicked#461
Open
horacioh wants to merge 1 commit into
Open
fix(web): open the profile view when "My Profile" is clicked#461horacioh wants to merge 1 commit into
horacioh wants to merge 1 commit into
Conversation
The account menu used `key: 'profile'` to navigate, but on web the profile view is rendered for `key: 'site-profile'`. Even though the URL produced by both was equivalent, the in-memory NavContext kept the wrong key after internal navigation, so `ResourcePage` fell through to render the home document instead of the profile. Use `key: 'site-profile'` with `tab: 'profile'` (matching the rest of the web app) so both the mobile sheet and the desktop dropdown in the account footer open the account's profile.
Collaborator
Author
|
@ericvicenti why web has a different key for profiles than the desktop app? |
Collaborator
|
Maybe we have a bug here, but to provide some context: on desktop app, the profile exists as a standalone page, and it should show activity for all sites. On web, it only exists within the same site, and the activity is meant to be filtered to that specific site. So I guess that is the main explanation for there being different keys |
Collaborator
|
On desktop the site-specific profiles also exist. But when you navigate to the profile it will take you to the generic one that exists outside the site |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The account menu used
key: 'profile'to navigate, but on web theprofile view is rendered for
key: 'site-profile'. Even though theURL produced by both was equivalent, the in-memory NavContext kept
the wrong key after internal navigation, so
ResourcePagefellthrough to render the home document instead of the profile.
Use
key: 'site-profile'withtab: 'profile'(matching the restof the web app) so both the mobile sheet and the desktop dropdown
in the account footer open the account's profile.