Surface hydromancer REST fallback and WS reconnects in traces - #141
Merged
Merged
Conversation
Thomasvdam
approved these changes
Jun 11, 2026
mariocao
approved these changes
Jun 16, 2026
Rate of fallback to REST and WS reconnect frequency are now queryable.
hacheigriega
force-pushed
the
feat/hydro-tracing
branch
from
August 14, 2026 13:25
4cc362f to
0b17cd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hydromancer module had no trace visibility into two operational events: when a request falls back to REST and when the upstream websocket reconnects. This tags the existing REST-fallback spans (
fetchAssetContextsFromRest,executeHydromancerRestRequest) with the reason it fired viaannotateSpans, and wraps each websocket connection attempt in aconnectHydromancerWsspan, so fallback rate and reconnect frequency are queryable instead of invisible.