feat: Add configurable Ingress hostname template for non-OpenShift cluster#1757
Open
osmman wants to merge 1 commit into
Open
feat: Add configurable Ingress hostname template for non-OpenShift cluster#1757osmman wants to merge 1 commit into
osmman wants to merge 1 commit into
Conversation
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
osmman
force-pushed
the
tturek/SECURESIGN-3862
branch
2 times, most recently
from
14ad068 to
7394be9
Compare
Collaborator
Author
|
/agentic_review |
Review Summary by Qodo(Agentic_describe updated until commit 4e3f148)Add configurable Ingress hostname template for non-OpenShift clusters
WalkthroughsDescription• Add configurable Ingress hostname template for non-OpenShift clusters • Default template "%[1]s.local" preserves existing behavior • CI configured with "%[1]s.%[2]s.traefik.me" for namespace-unique hostnames • Eliminates Ingress hostname collisions in e2e test namespaces Diagramflowchart LR
A["CLI Flag & Env Var"] -->|"--ingress-host-template"| B["Config Variable"]
B -->|"IngressHostTemplate"| C["CalculateHostname Function"]
C -->|"fmt.Sprintf"| D["Dynamic Hostname"]
D -->|"Service.Namespace.Domain"| E["Ingress Resource"]
File Changes1. cmd/main.go
|
Code Review by QodoLooking for bugs?Check back in a few minutes. An AI review agent is analyzing this pull request.
|
Code Review by Qodo
Context used 1. Unvalidated hostname template
|
osmman
force-pushed
the
tturek/SECURESIGN-3862
branch
from
7394be9 to
4e3f148
Compare
|
Persistent review updated to latest commit 4e3f148 |
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
…usters Introduces --ingress-host-template flag (INGRESS_HOST_TEMPLATE env var) to control default Ingress hostnames on non-OpenShift clusters. The default "%[1]s.local" preserves existing behavior. CI is configured with "%[1]s.%[2]s.127.0.0.1.nip.io" to produce namespace-unique hostnames, eliminating Ingress hostname collisions between e2e test namespaces that caused Konflux pipeline timeouts. Refs: SECURESIGN-3862 Signed-off-by: Tomas Turek <tturek@redhat.com>
osmman
force-pushed
the
tturek/SECURESIGN-3862
branch
from
4e3f148 to
9fd8d69
Compare
Collaborator
Author
|
Failure of Validate SecureSign / Test with custom operator installation (pull_request) is known flaky test |
bouskaJ
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces --ingress-host-template flag (INGRESS_HOST_TEMPLATE env var) to control default Ingress hostnames on non-OpenShift clusters. The default "%[1]s.local" preserves existing behavior. CI is configured with "%[1]s.%[2]s.traefik.me" to produce namespace-unique hostnames, eliminating Ingress hostname collisions between e2e test namespaces that caused Konflux pipeline timeouts.
Refs: SECURESIGN-3862