Add leichi algorithm to HEU by tomithy001 · Pull Request #80 · secretflow/heu

tomithy001 · 2023-07-30T11:22:23Z

[Feature] Add algorithm(leichi_paillier) which uses leichi to speed up Paillier

github-actions · 2023-07-30T11:22:37Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

tomithy001 · 2023-07-30T11:23:16Z

I have read the CLA Document and I hereby sign the CLA

heu/library/algorithms/leichi_paillier/ciphertext.cc

heu/library/algorithms/leichi_paillier/README.md

usafchn

所有的代码需要 format 一下

# c++
echo 'Formatting c++ code'
find . -type f -name '*.h' -o -name '*.cc' | xargs clang-format -i 

# bazel
echo 'Formatting bazel code'
buildifier -r .

usafchn · 2023-09-22T06:53:27Z

heu/library/algorithms/leichi_paillier/key_generator.cc

+        do{
+            get_prime(key_size/2,sk->p_);
+            get_prime(key_size/2,sk->q_);
+        }while(sk->p_ == sk->q_);


判断 gcd(p-1 ，q-1) == 2，从而确保 n - 1 没有小因子

防止 square-root attacks，需确保 p-q 是一个大整数

请参考一下这里的写法：
https://github.com/secretflow/heu/blob/main/heu/library/algorithms/paillier_zahlen/key_generator.cc#L41C1-L41C48

usafchn · 2023-09-22T06:56:55Z

heu/library/algorithms/leichi_paillier/key_generator_test.cc

+namespace heu::lib::algorithms::leichi_paillier::test {
+  class KeyGenTest : public ::testing::TestWithParam<size_t> {};
+  INSTANTIATE_TEST_SUITE_P(SubTest, KeyGenTest,
+                          ::testing::Values(1024));


根据安全要求，即使 UT 代码也不再允许出现 1024 keysize，以避免对用户产生误导

usafchn · 2023-09-22T06:58:43Z

heu/library/algorithms/leichi_paillier/key_generator_test.cc

+  TEST_P(KeyGenTest, SubTest) {
+    SecretKey sk;
+    PublicKey pk;
+    KeyGenerator::Generate(GetParam(), &sk, &pk);


这个单测啥都没测吗

我把这个单测加上

usafchn · 2023-09-22T07:00:17Z

heu/library/algorithms/leichi_paillier/leichi_test.cc

+
+namespace heu::lib::algorithms::leichi_paillier::test {
+
+    class LEICHITest : public testing::Test {


命名风格： LeichiTest

usafchn · 2023-09-22T07:02:05Z

heu/library/algorithms/leichi_paillier/leichi_test.cc

+        return BN_cmp(bn1, bn2);
+    }
+
+  TEST_F(LEICHITest, DISABLE_EncDec) {


这里的单测为什么都 Disable 了？

PR提交测试时需要硬件支持，否则会failed，把单测都Disable了

usafchn · 2023-09-22T08:37:49Z

heu/library/algorithms/leichi_paillier/public_key.h

+            };
+            void Deserialize(yacl::ByteContainerView in){
+                std::istringstream is((std::string)in);
+                BN_bin2bn((uint8_t *)(is.str().data()), is.str().size(),n_.bn_);


为什么要先转换成 istringstream ？

usafchn · 2023-09-22T08:41:01Z

heu/library/algorithms/leichi_paillier/utils.h

+    std::vector<uint8_t> Tobin(T &op)
+    {
+        uint32_t n_bits_len = op.numBits();
+        uint8_t* n_arr = new uint8_t[n_bits_len];


同上，不允许直接操作裸指针

usafchn · 2023-09-22T08:41:58Z

heu/library/algorithms/leichi_paillier/vector_decryptor.cc

+
+    Runtime _runtime;
+    std::vector<Plaintext> _pts(in_cts.size());
+    uint8_t *ct_bytes = new uint8_t[in_cts.size()*BYTECOUNT(pk_.n_.numBits()*2)];


请去掉 new

usafchn · 2023-09-22T08:44:19Z

heu/library/phe/encryptor_test.cc

 }

 TEST_P(EncryptorTest, MinMaxEnc) {
+  // if (GetParam() == SchemaType::Leichi) {


没用的注释去掉吧

usafchn · 2023-09-22T08:46:12Z

heu/library/phe/base/schema.h

  INVOKE(ENABLE_IPCL, func_or_macro, ::heu::lib::algorithms::paillier_ipcl, ##__VA_ARGS__) \
  INVOKE(true, func_or_macro, ::heu::lib::algorithms::paillier_z, ##__VA_ARGS__)           \
+  INVOKE(true, func_or_macro, ::heu::lib::algorithms::paillier_f, ##__VA_ARGS__) \
+  INVOKE(ENABLE_LEICHI, func_or_macro, ::heu::lib::algorithms::leichi_paillier, ##__VA_ARGS__)       \


leichi_paillier 加到 elgamal 之后，顺序与SchemaType enum相同

usafchn · 2024-01-09T07:45:56Z

heu/library/algorithms/leichi_paillier/runtime.cc

+        }
+    }
+
+    OPERATION_TYPE Runtime::operation_trans(std::string operation)


入参类型改成 const std::string & or std::string_view

usafchn · 2024-01-09T07:47:35Z

heu/library/algorithms/leichi_paillier/runtime.cc

+                break;
+            case 512:
+                count = 1;
+                break;


增加 default 语句并报错

usafchn · 2024-01-09T07:51:22Z

heu/library/algorithms/leichi_paillier/compiler/compiler.cc

+};
+
+std::map<std::string, int> CHIP_TABLE = {
+    {"CHIP_0",  (int) std::pow(2, 15)},


可以用移位代替

tomithy001 force-pushed the main branch from 1456de6 to 7d3df40 Compare August 8, 2023 12:26

Add leichi algorithm to HEU

f2097fc

tomithy001 force-pushed the main branch from 303eb75 to f2097fc Compare August 8, 2023 12:42

usafchn self-requested a review August 22, 2023 09:36

usafchn reviewed Aug 22, 2023

View reviewed changes

heu/library/algorithms/leichi_paillier/ciphertext.cc Outdated Show resolved Hide resolved

heu/library/algorithms/leichi_paillier/README.md Show resolved Hide resolved

tomithy001 added 2 commits September 13, 2023 04:53

modify copyright and Leichi product description.

30aa7e5

modify

50991e6

usafchn reviewed Sep 22, 2023

View reviewed changes

usafchn reviewed Jan 9, 2024

View reviewed changes


		namespace heu::lib::algorithms::leichi_paillier::test {

		class LEICHITest : public testing::Test {

Conversation

tomithy001 commented Jul 30, 2023

Uh oh!

github-actions bot commented Jul 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomithy001 commented Jul 30, 2023

Uh oh!

Uh oh!

Uh oh!

usafchn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Jul 30, 2023 •

edited

Loading