Skip to content

Update action.yml - #31

Open
andresborjas wants to merge 1 commit into
secret-scanner:mainfrom
andresborjas:patch-1
Open

Update action.yml#31
andresborjas wants to merge 1 commit into
secret-scanner:mainfrom
andresborjas:patch-1

Conversation

@andresborjas

Copy link
Copy Markdown

Update yelp detect secret version from 1.3.0 to 1.4.0

Update yelp detect secret version from 1.3.0 to 1.4.0
@jsoref

jsoref commented Sep 26, 2023

Copy link
Copy Markdown
Contributor

Thanks for the PR, I just tested it and things aren't looking good for a simple merge. I'm sure it's a bug in the wrapper itself.

failure details for my reference
usage: detect-secrets [-h] [-v] [--version] [-C <path>] [-c NUM_CORES]
                      {scan,audit} ...
Running detect-secrets with args: --exclude-files .*-sealed.json$ --exclude-files .*-sealed.yml$ --exclude-files .*-sealed.yaml$ --exclude-files .*/latestVersion.dhall$ --exclude-files .github/actions/spelling-data/.*  --exclude-secrets ^SG.w{22}.w{43}$  --exclude-lines ^.*tag.*$ --exclude-lines ^s+withs+imageTags*=.*$ --exclude-lines ["']?googleMapsApiKey["']?: ["']?w+["']?  
detect-secrets: error: unrecognized arguments: ["']?w+["']?
jq: error (at /tmp/tmp.VkATJFUQqZ:608): Cannot index array with string "category"
# Secret Scanner Report
## Potential new secrets discovered
|FILE|LINES|TYPES|
|----|-----|-----|

I have a branch I started working on to resolve the problems:
https://github.com/jsoref/secret-scanner-action/tree/perl

They don't always happen, but do often enough to justify rewriting the glue. I suspect this upgrade was why I started working on it, but, it was a while ago.

I will try to get it merged this week (which probably involves finishing off the above branch).

@ghinch

ghinch commented May 22, 2024

Copy link
Copy Markdown

Any idea when this might get fixed?

A quick glance, seems like the fix could be a change to

jq 'map(select(.category == "UNVERIFIED"))' "$all_secrets_file" > "$new_secrets_file"

Such as:
jq -r '.results[] | select(.category == "UNVERIFIED")' "$all_secrets_file" > "$new_secrets_file"

This would omit VERIFIED_TRUE secrets though.

Alternatively could add the --only-real flag to line 33 and omit line 34 altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants