Fix metadata modal not scrolling on desktop#936
Merged
underbluewaters merged 2 commits intomasterfrom May 7, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/seasketch/next/sessions/fe13da93-b542-4f73-85e4-4a06299c7152 Co-authored-by: underbluewaters <511063+underbluewaters@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix metadata windows to enable scrolling
Fix metadata modal not scrolling on desktop
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long metadata content was clipped on desktop — the modal panel overflowed the viewport with no way to scroll to the rest of the content.
Root cause
Modalusessm:overflow-y-hiddenon its outer wrapper to prevent page scroll on desktop, relying on thescrollableprop to opt the body div intosm:overflow-y-auto+sm:flex-1within amax-h-[90vh]flex column.MetadataModalnever passedscrollable, so content beyond the viewport was silently clipped by the panel'soverflow-hidden.Change
MetadataModal.tsx— addscrollableto the<Modal>render: