Skip to content

chore(specmill): bump toolkit to 0.4.0 - #380

Open
seanthimons wants to merge 1 commit into
mainfrom
chore/specmill-0.4.0
Open

seanthimons wants to merge 1 commit into
mainfrom
chore/specmill-0.4.0

Conversation

@seanthimons

Copy link
Copy Markdown
Owner

Bumps the Specmill pin from 0.2.3 to 0.4.0 (seanthimons/specmill@b913424a), the release that includes seanthimons/specmill#318, with Rscript dev/bump_specmill.R v0.4.0.

Changes

  • dev/specmill-lock.json, dev/specmill-342/adoption.json and .specmill/manifest.json record the new pin.
  • R/z_specmill_request.R is unchanged.
  • The generated R/api_auth.R gains OAuth PKCE sign-in support. ComptoxR configures no OAuth credentials, so the code is inactive and nothing new is exported.

Verification

  • All bump-script checks pass (check_public_api, check_hook_config, specmill-342 and specmill-333 verify, generate_specmill.R --check, generate_tests.R --check).
  • devtools::test(): 11494 passed, 0 failed, 3 skipped.

Note

#379 also adds a NEWS "Unreleased" section and changes .specmill/manifest.json. Whichever merges second needs main merged in and Rscript dev/generate_specmill.R --apply.

Request helper unchanged. The generated authentication file gains OAuth
sign-in support, which ComptoxR does not configure.
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 1.41509% with 209 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
R/api_auth.R 1.41% 209 Missing ⚠️

📢 Thoughts on this report? Let us know!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants