Skip to content

ltimer: enable timer for QEMU Arm arch timers #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
midnightveil wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −3
Open

ltimer: enable timer for QEMU Arm arch timers #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions libplatsupport/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,14 @@ config_choice(
mark_as_advanced(CLEAR LibPlatSupportX86ConsoleDevice LibPlatSupportLPTMRclock)

# Some platforms don't have a platform timer.
if(
(KernelPlatformQEMUArmVirt AND NOT (KernelArmExportPCNTUser AND KernelArmExportPTMRUser))
OR KernelPlatformRocketchip
if(KernelPlatformQEMUArmVirt)
Copy link
Copy Markdown
Member

@axel-h axel-h Jul 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general question, why are we explicitly checking for KernelPlatformQEMUArmVirt here actually, can't this be made KernelArchARM to make this generic?

Below in line 124 there is this, which make we wonder why we don't check KernelPlatformQuartz64/KernelPlatformIMX93 here then also

if(KernelPlatformQEMUArmVirt OR KernelPlatformQuartz64 OR KernelPlatformIMX93)
    if(KernelArmExportPCNTUser AND KernelArmExportPTMRUser)
        list(APPEND deps src/arch/arm/generic_ltimer.c)
    endif()
endif()

if(KernelArmExportPCNTUser AND KernelArmExportPTMRUser)
set(LibPlatSupportHaveTimer ON)
else()
set(LibPlatSupportHaveTimer OFF)
endif()
elseif(
KernelPlatformRocketchip
OR KernelPlatformRocketchipZCU102
OR KernelPlatformCheshire
OR (SIMULATION AND (KernelArchRiscV OR KernelArchARM))
Expand Down