Conversation
sds
left a comment
There was a problem hiding this comment.
Thanks so much for opening this pull request, @guillaume-d. Very excited to move this forward.
Left a few comments to clarify how we could potentially make this experience a seamless one without having to introduce the concept of an "ad hoc" hook to the configuration format. Curious to get your perspective.
sds
left a comment
There was a problem hiding this comment.
Sincere apologies for the very slow response, @guillaume-d. Let me know your thoughts!
No problem, was started to worry something bad may have happened. |
1438fa3 to
34bf2c8
Compare
f5f0d60 to
72ed54f
Compare
72ed54f to
3dc1d14
Compare
Hi. I think all comments have finally been adressed now. I am afraid I will not have much more time to do another review round (except maybe if feedback is very minor and comes fast, before I get sidetracked by other things). If nothing comes I will just use my fork of overcommit going forward, and use #758 and future uses of this feature from there. |
Include some (partly regression) tests and a small doc.