Repository navigation
fix: workflow step — mitigated+firing → executing, approval gate priority - #1
Merged
Merged
Conversation
…re mitigated check Two bugs in computeWorkflowStep: 1. When incident is mitigated but firing alerts remain, the function returned 'verifying' instead of 'executing'. With firing alerts still present, metrics haven't settled yet — the agent should still be executing (cooldown period), not verifying. 2. The approved confirmation check ran after the mitigated check, so an incident that was both mitigated and had an approved confirmation returned 'verifying' instead of 'executing'. Approval gate must take priority so the agent proceeds with the approved action. Fixes the two failing tests: - incident mitigated + firing alerts → executing - approved confirmation takes priority over mitigated status
- Update actions/checkout from v4 to v5 in CI workflow - Add 'depends: [install]' to mise test task so dependencies are installed before running tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs in
computeWorkflowStepthat caused 2 test failures on main.Bugs
Mitigated + firing alerts returned
"verifying"instead of"executing""executing", not"verifying".firingAlerts.length === 0 → "resolved"check earlier — so"verifying"for mitigated was effectively dead code given the current call pattern.Approved confirmation check ran after mitigated check
"verifying"instead of"executing". The approval gate must take priority so the agent proceeds with the approved action.Fix
"executing"(cooldown semantics).Test results
All 16 workflow-step tests pass. (The
typeboxerror inapproval-gate.test.tsis pre-existing on main, unrelated to this change.)